jesicabaxter / ndmitchell

Automatically exported from code.google.com/p/ndmitchell
0 stars 0 forks source link

HLint default data file search can be problematic #620

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
HLint currently looks for the hint file (either one passed in or the default) 
first in the current directory and only then in the data directory.

This is not a problem in general, but it can lead to unintended rule changes, 
and for example makes it impossible to run HLint from its own src/ directory 
(since HLint.hs in there is not a hints file). The problem is that you can't 
disable this behaviour.

I'm thinking that lookup in the current directory should be attempted only if 
there is an explicit hint file passed in, and by default the hint file should 
only be looked up from the data directory. Thoughts? If you agree, I could send 
a patch.

Original issue reported on code.google.com by ius...@google.com on 28 Aug 2013 at 1:28

GoogleCodeExporter commented 8 years ago
The behaviour you describe sounds more sensible, a patch would be most welcome. 
Note that HLint is now hosted at github: https://github.com/ndmitchell/hlint

Original comment by ndmitch...@gmail.com on 28 Aug 2013 at 3:42

GoogleCodeExporter commented 8 years ago
https://github.com/ndmitchell/hlint/issues/70

Original comment by ndmitch...@gmail.com on 23 Jul 2014 at 6:45