search

jesjos / active_record_upsert

Upsert for Rails 5 / Active Record 5
MIT License
207 stars 51 forks source link

Rails 7.0 support #120

Closed misdoro closed 2 years ago

misdoro commented 2 years ago

Add rails 7 to the tests matrix, copy-paste rails 6.0 compatibility layer as rails 7.

misdoro commented 2 years ago

:thinking: Weird, it did not trigger any github actions.

misdoro commented 2 years ago

It doesn't really work yet, and it should be draft until the CI is fixed.

olleolleolle commented 2 years ago

@misdoro i squashed and merged the other PR, thanks for the fix.

misdoro commented 2 years ago

Thanks @olleolleolle , the tests are passing now even for rails 7 :tada:

No guarantees that the code is optimal or whatsoever, I am far from being an expert in active record :)

nickcampbell18 commented 2 years ago

I can't comment on the performance as such, but I've incorporated this fork into one of my applications and it seems to work in Rails 7.0.0 as well as on Rails 6.1.4 🎉

olleolleolle commented 2 years ago

Let's get this merged!