search

jesjos / active_record_upsert

Upsert for Rails 5 / Active Record 5
MIT License
207 stars 51 forks source link

Run tests using Ruby 2.6, 2.7 and 3.0, clarify EOL policy #122

Closed nickcampbell18 closed 2 years ago

nickcampbell18 commented 2 years ago

Note that Rails 6+ does not run on Ruby 2.6, so they must be explicitly excluded from testing - see rails/rails#40938.

I also had to fix some issues with Ruby 3 keyword arguments, see the second commit.

Closes https://github.com/jesjos/active_record_upsert/issues/116

olleolleolle commented 2 years ago

Now, with these changes in arity, will people have to... uh, change their invocations?

nickcampbell18 commented 2 years ago

In short, I don't think so - in Ruby 2.6, their old code should work fine, in Ruby 2.7 it generates a warning now, and in Ruby 3+ we already had to use this syntax (I should know since I'm using this in a Ruby 3.0 application already)