search

jesjos / active_record_upsert

Upsert for Rails 5 / Active Record 5
MIT License
207 stars 51 forks source link

Add support for Ruby 3.2 and Rails 7.1 #139

Closed jgraichen closed 1 year ago

jgraichen commented 1 year ago

Add support for Rails 7.1 on Ruby 3.2.

There doesn't seem to be any changes needed, all tests passed locally (PG 16). I'd love to upgrade a few of my apps to Rails 7.1 keeping this wonderful gem :+1:.

One commit fixes the version constraints in the Gemfile.* files. Most specified only e.g. ~> 6.0 (meaning 6.x) and happily installed Rails 6.1 when only 6.0 was intended. Another commit updates the README if that is fine.

olleolleolle commented 1 year ago

Ah, learning more about the next version of Rails here: the rails-main tests fail, and have warnings like

NoMethodError: undefined method `rollback_active_record_state!' for #<MyRecord id: 0, name: nil, wisdom: nil, created_at: nil, updated_at: nil>

No action needed. Merging this!

olleolleolle commented 1 year ago

I also found this, (cc @jesjos):

The base branch requires all commits to be signed. Learn more about signing commits.

jgraichen commented 1 year ago

The base branch requires all commits to be signed.

Added that :+1:

jgraichen commented 12 months ago

@olleolleolle Would it be possible to get a new gem release with the Rails 7.1 compatibility?