search

jesjos / active_record_upsert

Upsert for Rails 5 / Active Record 5
MIT License
207 stars 51 forks source link

Add upsert_keys and upsert_options as opts #93

Closed hahuang65 closed 4 years ago

hahuang65 commented 5 years ago

This allows setting of upsert_keys and upsert_options directly when calling #upsert or .upsert. This will overwrite the default upsert_keys and upsert_options set in the model.

Resolves https://github.com/jesjos/active_record_upsert/issues/74

hahuang65 commented 5 years ago

I can't seem to figure out why these tests are failing for Rails 5.1 and 5.0. The index looks to be in place from those Travis logs...

hahuang65 commented 5 years ago

Never mind, figured it out. There was a change I needed to make in the compatibility layer.

perezpaya commented 5 years ago

+1 That will be really helpful

hahuang65 commented 4 years ago

Any chance we can get this in?