You don't have this example in your repo, so no pull request. I tried this with the two alcatraz pics you're using in the book, and the error looks smaller with this change (http://i.imgur.com/3md1jMp.jpg) than without it (http://i.imgur.com/VhJQ5mM.jpg) there too.
(It's of course possible I got some other bit of my code wrong which happens to require this fix. I triple-checked that I didn't, but who knows. Maybe you can publish your code for the 3d reconstruction example in chapter 5, then I could check if it works with my input images without modifications.)
See commit https://github.com/nico/cvbook/commit/102a8b098664cfff1f5be85fbd0de9fd72d1b8e2 – the arguments to
F_from_ransac()need to be swapped.You don't have this example in your repo, so no pull request. I tried this with the two alcatraz pics you're using in the book, and the error looks smaller with this change (http://i.imgur.com/3md1jMp.jpg) than without it (http://i.imgur.com/VhJQ5mM.jpg) there too.
(It's of course possible I got some other bit of my code wrong which happens to require this fix. I triple-checked that I didn't, but who knows. Maybe you can publish your code for the 3d reconstruction example in chapter 5, then I could check if it works with my input images without modifications.)