search

jesolem / PCV

Open source Python module for computer vision
BSD 2-Clause "Simplified" License
1.92k stars 672 forks source link

Small bug in sift.py of PCV-note #28

Open takeshi-a opened 8 years ago

takeshi-a commented 8 years ago

Hi Jan Erik,

I found a small bug in the code of PCV/pcv_book/sift.py. https://github.com/jesolem/PCV/blob/master/pcv_book/sift.py

In the line 112, it is written like below,

plot([locs1[i][1],locs2[m][1]+cols1],[locs1[i][0],locs2[m][0]],'c')

This line is different from the code of PCV/PCV/localdescriptors/sift.py. https://github.com/jesolem/PCV/blob/master/PCV/localdescriptors/sift.py

plot([locs1[i][0],locs2[m][0]+cols1],[locs1[i][1],locs2[m][1]],'c')

As you can see, X-Y coordinates are written differently between the two files, and the latter is correct. Since I used the first one in my practice, I've been stuck on drawing the corresponding lines.

I would be happy if this message helps you.

Best, Takeshi

jesolem commented 8 years ago

Thanks. Yes, I found the problem which is why the PCV code has the right version. Was hesitant to update the book code...

takeshi-a commented 8 years ago

Hi! It's my pleasure to find such bugs and to let you know. Because you made an excellent book, PCV, you are qualified. Please keep in touch. I'll keep on going with your book.

Takeshi

2016/07/22 19:59$B!"(BJan Erik Solem notifications@github.com $B$N%a%C%;!<%8(B:

Thanks. Yes, I found the problem which is why the PCV code has the right version. Was hesitant to update the book code...

$B!=(B You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.