search

jesrav / footy-tracker

4 stars 1 forks source link

Tests/added unit tests (Sourcery refactored) #33

Closed sourcery-ai[bot] closed 1 year ago

sourcery-ai[bot] commented 1 year ago

Pull Request #32 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the tests/added-unit-tests branch, then run:

git fetch origin sourcery/tests/added-unit-tests
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai[bot] commented 1 year ago

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 109.40 🙂 109.40 🙂 0.00
Working memory 6.50 🙂 6.50 🙂 0.00
Quality 76.05% ⭐ 76.05% ⭐ 0.00%
Other metrics Before After Change
Lines 127 127 0
Changed files Quality Before Quality After Quality Change
src/api/api/services/team_suggestion.py 76.05% ⭐ 76.05% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/api/api/services/team_suggestion.py prepare_data_for_user_combination_prediction 0 ⭐ 213 ⛔ 9 🙂 59.53% 🙂 Try splitting into smaller methods
src/api/api/services/team_suggestion.py suggest_most_fair_teams 0 ⭐ 122 😞 7 🙂 72.75% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!