search

jessarcher / laravel-castable-data-transfer-object

Automatically cast JSON columns to rich PHP objects in Laravel using Spatie's data-transfer-object class
https://jessarcher.com/blog/casting-json-columns-to-value-objects/
MIT License
328 stars 23 forks source link

Allow Laravel 9 #11

Closed DanielGSoftware closed 2 years ago

DanielGSoftware commented 2 years ago

This PR allows for Laravel 9.

DanielGSoftware commented 2 years ago

Php-cs-fixer check fails, tried fixing it but can't find why it's failing... can you maybe have a look @jessarcher ? Thanks, and thank you for this awesome package!

jessarcher commented 2 years ago

Hey @DanielGSoftware, thanks for this!

I think I've fixed the php-cs-fixer issue. There was also a weird issue with the combo of Laravel 8, PHP 8.1, and --prefer-lowest that I've also fixed.

There's still an annoying dependency issue with the windows tests that I'll need to take a closer look at, but I don't have a windows machine to experiment locally.

DanielGSoftware commented 2 years ago

Nice! As for the windows test failing, I do have a windows machine but I don't have access to it till monday. Maybe I can have a look then

jessarcher commented 2 years ago

Cool, let me know how you go. If we can't solve it I will probably just remove the Windows tests.

DanielGSoftware commented 2 years ago

@jessarcher I tried it on my windows machine, everything worked fine.. so then I made a pr on my own repo to rerun the tests and.. they all pass! Look's like it fixed itself, just gotta rerun the tests but I can't do that here

jessarcher commented 2 years ago

@DanielGSoftware Hah! Awesome! I will get this merged and released. Thanks for your help :)