search

jesse-ai / jesse

An advanced crypto trading bot written in Python
https://jesse.trade
MIT License
5.73k stars 732 forks source link

Better estimation on candle import #436

Closed kakulukia closed 7 months ago

kakulukia commented 7 months ago

Lets say you already have a year worth of data, but forgot about the warmup_candles. Or you want to test larger time frames and need even more candles now. This will screw up the estimated time for the import.

This change allows an additional completed parameter for the Progressbar and uses that while importing candles. This way the estimated_remaining_seconds will take into account that most of the work might be done already.

saleh-mir commented 7 months ago

This idea is good, but it disrupts the remaining time feature in some cases. Currently, the remaining time adjusts based on execution duration. With this PR, it returns zero when the candle exists, even if execution is fast and there is still some remaining time like 6 or 7 seconds. After testing, it keeps displaying "please wait," indicating zero time for those cases.

kakulukia commented 7 months ago

We could say it needs a few milliseconds to check each candle. Didn't check the algo in much detail, I guess it only records time, if there is a request to an exchange. Let me have another look.

saleh-mir commented 7 months ago

Please don't spend too much time on it. Your solution is clever, but I don't think the issue is actually bothering anyone.

kakulukia commented 7 months ago

It was bothering me as I was importing additional candles due to the warmup I did not have enough. I guess I'm not the only one. But yes, this is s but lower on my to-do list.