jesse-ai / jesse

An advanced crypto trading bot written in Python
https://jesse.trade
MIT License
5.71k stars 733 forks source link

Jesse docker image not support arm64 by default #480

Open abdulbasetbasher opened 1 month ago

abdulbasetbasher commented 1 month ago

docker image built only for amd64 and that make it run slow on apple silicon cpu , windows on arm or linux arm64.

image

I built the image but with change line 11 on docker_build_helpers/install_ta-lib.sh

to && ./configure --build=aarch64-unknown-linux-gnu --prefix=${INSTALL_LOC}/ \

and its works fine and the performance is good.

saleh-mir commented 1 month ago

Either when you build it that way, will it also work for x86 machines, or do we have to build a separate one ARM a separate one for x86 machines?

abdulbasetbasher commented 1 month ago

Either when you build it that way, will it also work for x86 machines, or do we have to build a separate one ARM a separate one for x86 machines?

im not expert on docker but docker hub support multi arch image via buildx or manifest, the python image that jesse built on it follow that approach btw.

that way its easy for me to build arm64 image on my apple m2 machine

it will be easy to build multi arch image using GitHub Actions and buildx.

saleh-mir commented 1 month ago

Thank you, that's very helpful.

abdulbasetbasher commented 1 month ago

Thank you, that's very helpful.

check it out https://docs.docker.com/build/ci/github-actions/multi-platform/

only thing need to figure out is how to make arch dynamic in /install_ta-lib.sh

saleh-mir commented 1 month ago

Other than that, I didn't know I could build Docker images with GitHub Actions. I was using a separate VPS for it, so this will save me money as well.

antevis commented 1 week ago

@saleh-mir opened a PR for this: https://github.com/jesse-ai/jesse/pull/485