search

jesseadams / sphinx-cookbook

Chef cookbook for Sphinx Search (searchd)
14 stars 27 forks source link

add back missing variables used when use_stemmer=true #27

Closed kesor closed 10 years ago

kesor commented 10 years ago

When source cookbook was refactored into http and svn, some variables got removed that are still used when use_stemmer=true.

jesseadams commented 10 years ago

Should we add a test or two to verify the stemmer stuff? I'd like to ensure it doesn't break in the future.

kesor commented 10 years ago

Is it a line or two in kitchen.yml that add variables and that's it?

Evgeny

On Wed, Dec 18, 2013 at 8:58 PM, Jesse Adams notifications@github.com wrote:

Should we add a test or two to verify the stemmer stuff? I'd like to ensure it doesn't break in the future.

Reply to this email directly or view it on GitHub: https://github.com/jesseadams/sphinx-cookbook/pull/27#issuecomment-30869700

jesseadams commented 10 years ago

Ideally we would:

  1. Add a ChefSpec that verifies a stemmer configuration completes without errors and does the extras we expect. This will be ran via Travis each time a pull request is made.
  2. Add an integration test to test/cookbooks/sphinx_test/files/default/tests/minitest that verifies a stemmer configuration completes as expected. This is ran before I build a new version.
jesseadams commented 10 years ago

I am going to merge it for now. I would really like to get some tests on this though.