search

jessecooper / pyetrade

Python E-Trade API Wrapper
GNU General Public License v3.0
209 stars 97 forks source link

stopPrice #41

Closed hyungmok closed 3 years ago

hyungmok commented 3 years ago

https://github.com/jessecooper/pyetrade/blob/289bdb84ff0bb596f4780c13e5a57d3ab0758e51/pyetrade/order.py#L159

Hi, folks.

I have a question on the line 159. I may be wrong, but to my understanding the stopPrice is always an empty string, which means it would be useless even if I pass a stop price in the payload. Can anyone please advise me on this?

Thanks!

rrupesh commented 3 years ago

This is one nasty bug! :) and simple to fix. please fix this.

jessecooper commented 3 years ago

@rrupesh PRs are always encouraged.

jessecooper commented 3 years ago

fixed in 1.2.2