search

jessecooper / pyetrade

Python E-Trade API Wrapper
GNU General Public License v3.0
205 stars 96 forks source link

fix issue #41 #50 order["stopPrice"] is always empty #51

Closed mw66 closed 3 years ago

mw66 commented 3 years ago

fix issue #41 #50 order["stopPrice"] is always empty

mw66 commented 3 years ago

@jessecooper can you review this PR?

jessecooper commented 3 years ago

@mingwugmail would you be comfortable adding unit tests around this functionality to make sure there are no regressions in the future?

mw66 commented 3 years ago

@mingwugmail would you be comfortable adding unit tests around this functionality to make sure there are no regressions in the future?

@jessecooper Done.

mw66 commented 3 years ago

@mingwugmail would you be comfortable adding unit tests around this functionality to make sure there are no regressions in the future?

All "SELL", "SELL_SHORT", "BUY", "BUY_TO_COVER" tested.

jessecooper commented 3 years ago

@mingwugmail thank you for the contribution