search

jessecooper / pyetrade

Python E-Trade API Wrapper
GNU General Public License v3.0
205 stars 96 forks source link

add place_option_order() #54

Closed mw66 closed 2 years ago

mw66 commented 2 years ago

fix https://github.com/jessecooper/pyetrade/issues/13 for single CALL / PUT leg

add place_option_order() add place_changed_option_order()

fix: https://github.com/jessecooper/pyetrade/issues/49 refactoring get_request_result(),

mw66 commented 2 years ago

@jessecooper this is ready for review.

I've tested to trade options with real Etrade server, and it's working.

jessecooper commented 2 years ago

Give me some time to review and test. Thank you for the contribution.

mw66 commented 2 years ago

Pls take another look.

mw66 commented 2 years ago

@jessecooper pls take another look.

I just want to get the functionality in. Feel free to change / refactor the code after the merge, I don't mind.

jessecooper commented 2 years ago

@mw66 please be patient with me in this review. I am still walking through it myself. I try to take my time on these reviews for a few reasons. Security being one of them. I understand it can be frustrating to have a long review period but I do appreciate your contribution and understanding.

mw66 commented 2 years ago

no problem, take your time.

yui410122 commented 2 years ago

@jessecooper this is ready for review.

I've tested to trade options with real Etrade server, and it's working.

@jessecooper this is ready for review.

I've tested to trade options with real Etrade server, and it's working.

Hey @mw66 , I am also working on similar stuff and trying to use Etrade API to place option order, when I tested my code, the BUY_OPEN order action works, but SELL_OPEN does not, wonder if you've tested this and know what we need to change to make the SELL_OPEN work as well? Thanks!

[Edited] Never mind, I think the reason it doesn't work for SELL_OPEN for me is because there's no sufficient fund in my account and Etrade just returns a none valid response without any useful info so I thought it's not working. After testing on a cheaper stock I was able to make the SELL_OPEN order as well.

jessecooper commented 2 years ago

@mv66 please make the final changes and I will merge this in.

mw66 commented 2 years ago

No more change. Refactoring was the last one.

jessecooper commented 2 years ago

No more change. Refactoring was the last one.

@mw66 sorry I didn't realize my comments were not yet visible to you.

jessecooper commented 2 years ago

@mw66 Thank you for your patients

mw66 commented 2 years ago

@jessecooper you want to make a new release? so pip upgrade can pick up the new version?

jessecooper commented 2 years ago

@mw66 I will do this as soon as possible. I have a few things to do before releasing but it should be out shortly.

jessecooper commented 2 years ago

released in 1.3.4