jessecooper / pyetrade

Python E-Trade API Wrapper
GNU General Public License v3.0
205 stars 96 forks source link

add pyetrade/automatedTrading.py #65

Closed mw66 closed 2 years ago

mw66 commented 2 years ago

The file is from:

https://github.com/charley-padron/Trading-System/blob/master/automatedTrading.py

with modifications.

To use, one also need the sample config.ini: https://github.com/charley-padron/Trading-System/blob/master/config.ini

mw66 commented 2 years ago

@jessecooper

This will properly close: #63 #56 #62

jessecooper commented 2 years ago

Hi @mw66, I truly appreciate the PR as the feature has been requested a lot but like I said in #63 this feature is outside of the scope of the Etrade API and further might even violate the terms & conditions of Etrade (I am unsure of this). That is why I encouraged this to be moved into the Discussions. This would also bring in some heavy new requirements into the project that are not called out in the PR selenium and pandas. There are other ways to implement this with just bs4. I am going to close this out and if you would like to put this in a Gist and post it in the discussion that would probably be a better place for it than directly in the project. The scope of pyetrade is to be a Python binding to the Etrade API. Other logic is the responsibility of the application that imports pyetrade.