jessedc / JCTiledScrollView

A set of classes that wrap UIScrollView and CATiledLayer. It aims to simplify displaying large images and PDFs at multiple zoom scales.
MIT License
310 stars 47 forks source link

A set of annotation delegate callbacks for JCTiledScrollViewDelegate #16

Closed adamotte closed 11 years ago

adamotte commented 11 years ago

I did a more complete set of delegate callbacks :

-(void)tiledScrollView:(JCTiledScrollView *)scrollView annotationWillDisappear:(id)annotation;
-(void)tiledScrollView:(JCTiledScrollView *)scrollView annotationDidDisappear:(id)annotation;

-(void)tiledScrollView:(JCTiledScrollView *)scrollView annotationWillAppear:(id)annotation;
-(void)tiledScrollView:(JCTiledScrollView *)scrollView annotationDidAppear:(id)annotation;

-(void)tiledScrollView:(JCTiledScrollView *)scrollView didSelectAnnotationView:(JCAnnotationView *)view;
-(void)tiledScrollView:(JCTiledScrollView *)scrollView didDeselectAnnotationView:(JCAnnotationView *)view;
spry commented 11 years ago

Any chance of getting this integrated?

jessedc commented 11 years ago

To be honest I've been lazy here. The additions look like a reasonable set of new callbacks.

If was being particular, I'd ask for the extra comments throughout to be removed and the indentation brought back in line withe the rest of the project.

eg large comments are not required:

//************* Anthony D modifications ****************//

It will also not merge these days because I've moved things to ARC.

@spry It wouldn't be hard to recreate the logic and submit a fresh PR.

jessedc commented 11 years ago

Closing because I'll merge #21

adamotte commented 11 years ago

Thanks ;)