search

jesseditson / jss

A styleguide generator based on kss (https://github.com/kneath/kss), but built in node.js
25 stars 8 forks source link

The example demo does not fully work #2

Closed tranzfuse closed 12 years ago

tranzfuse commented 12 years ago

Hi, perhaps I've done something wrong, (it's not obvious what it is if I have) but the views are not properly updating when the different navigation links (Home, Styleguide) are clicked to display the different pages.

I tried to debug the app, and I still couldn't quite put my finger on where the exact problem was. As best as I can tell the actual requests are being made (watching the network panel in the console shows files being requested and served), but the contents of the layout var seem to be cached from the initial request and never get updated. The layout var is defined in your getPage function. It's weird because the body argument being passed to that function is correct (or it seems to be when I log its value to the console).

If I restart the app and visit the other page (if I originally visited / then after restart I would originally visit styleguide/) it would load right up.

I hope my description makes sense. I wonder if others have run into this issue as well?

I'd love to get this working properly, I can't use KSS since it's so tightly coupled to ruby, so this node version would do the trick.

Thanks for your efforts.

jesseditson commented 12 years ago

I haven't played with this stuff in a while, it could definitely use a brush-up - I'll jump on this asap and get it working as soon as I have some spare minutes - thanks for the heads up!

tranzfuse commented 12 years ago

One other thought is that there might be an issue with one of the module dependencies. I noticed in your package.json you didn't specify versions of any of the modules your app requires, so it's possible that something has changed in a later version since you released your app. I would recommend specifying versions in the next iteration regardless.

jesseditson commented 12 years ago

That's definitely a mistake on my part. I'll add those in the next fix. Are you running 0.8.x or 0.6.x?

Sent from my iPhone

On Sep 24, 2012, at 10:57 AM, Adam Smith notifications@github.com wrote:

One other thought is that there might be an issue with one of the module dependencies. I noticed in your package.json you didn't specify versions of any of the modules your app requires, so it's possible that something has changed in a later version since you released your app. I would recommend specifying versions in the next iteration regardless.

— Reply to this email directly or view it on GitHubhttps://github.com/jesseditson/jss/issues/2#issuecomment-8828022.

tranzfuse commented 12 years ago

node v0.8.7 here.

jesseditson commented 12 years ago

Hey, sorry I'm super busy, but found some moments to clean up the example and make it work - deps are all defined now, and 0.1.2 is published to npm - let me know if you have further issues, I'll be using this project again soon, but it's been a little neglected. If I can work it in to my daily flow again I'll be updating much more often.

tranzfuse commented 12 years ago

Works fine now, thank you very much! I'll keep an eye on the project, and I also plan to begin using it in my own work. Perhaps I can contribute to the project down the road.

Cheers!

Adam

On Tue, Sep 25, 2012 at 4:35 PM, Jesse Ditson notifications@github.comwrote:

Hey, sorry I'm super busy, but found some moments to clean up the example and make it work - deps are all defined now, and 0.1.2 is published to npm

  • let me know if you have further issues, I'll be using this project again soon, but it's been a little neglected. If I can work it in to my daily flow again I'll be updating much more often.

— Reply to this email directly or view it on GitHubhttps://github.com/jesseditson/jss/issues/2#issuecomment-8869203.

Adam Smith http://about.me/adamcsmith