fix install script, for crystal 0.20, fixed #27

jessedoyle / duktape.cr

Evaluate JavaScript from Crystal!

MIT License

137 stars 17 forks source link

Closed kostya closed 7 years ago

jessedoyle commented 7 years ago

Thanks @kostya!

I remember throwing the ext directory within src because shards did not copy the entire shard directory into the libs folder.

I wonder if it's better to just move the ext directory back a level out of src now that this behaviour has changed?

Currently, I think that's a cleaner solution. But this PR definitely solves the problem as well.

I'll open up a PR with the alternate solution and we can compare!

jessedoyle commented 7 years ago

Here's a PR that should solve the issue as well. I think I'm going to continue with this pattern.

Thanks for the PR @kostya!