Fix Inline Icon Render Position - Githubissues

jessedoyle / prawn-icon

Easy icons for Prawn.

Other

31 stars 15 forks source link

Fix Inline Icon Render Position #25

Closed jessedoyle closed 8 years ago

jessedoyle commented 8 years ago

This PR fixes a bug reported in #24 that affects the render position of inline icons.

Here's the changes for the following code:

Prawn::Document.generate('test.pdf') do |pdf|
  pdf.text 'Start'
  pdf.move_down 10
  pdf.text 'More'
  pdf.move_down 20
  pdf.icon '<icon>fa-info-circle</icon> icon here!', inline_format: true
  pdf.move_down 30
  pdf.text 'End'
end

Before Fix:

screen shot 2016-06-24 at 10 36 14 pm

After Fix:

screen shot 2016-06-24 at 10 37 02 pm

Detailed Notes

Modify inline_icon method to render at the cursor position and perform a dry_run render of the Text::Formatted::Box to determine the height of the box.
The y position is then moved down the height of the text box (with line gap and leading if applicable).
Add spec to test for the correct inline icon render position (#24).
Update version to 1.1.1.
Update Changelog.