search

jessedoyle / prawn-icon

Easy icons for Prawn.
Other
28 stars 15 forks source link

update font awesome to latest version #32

Closed aoyawale closed 6 years ago

aoyawale commented 6 years ago

is it possible to update to latest version?

jessedoyle commented 6 years ago

Hi @jlozadad - it absolutely is possible to update FontAwesome to version 5.

Unfortunately, this is a breaking change as FontAwesome 5 is not backwards compatible so we'll have to release a 2.0 version of Prawn::Icon.

I can look into this over the next week or so, but PRs are absolutely welcome!

All that would have to change is the "legend" YAML file and ttf file for FontAwesome here: https://github.com/jessedoyle/prawn-icon/tree/master/data/fonts/fa.

I've written a helper script to take the FontAwesome _variables file and create a proper legend YAML file.

I'm not sure if it'll work with FontAwesome 5, but the script is here.

aoyawale commented 6 years ago

thanks for the info! I'll check it out and see what I can do.

jessedoyle commented 6 years ago

@jlozadad - I've started a branch here. I was hoping to avoid breaking changes as much as possible, but it looks like FontAwesome split up their icons into multiple font files.

Do you mind trying out the branch? I'd like to get your opinion on the changes.

Thanks!

jessedoyle commented 6 years ago

Fixed in https://github.com/jessedoyle/prawn-icon/pull/33