search

jessedoyle / prawn-icon

Easy icons for Prawn.
Other
28 stars 15 forks source link

added positions for inline icons #42

Closed navinspm closed 4 years ago

jessedoyle commented 4 years ago

Hi @navinspm! Thanks so much for the contribution!

I just noticed that the TravisCI automation I had previously setup is no longer working - I'm going to make a few PRs first to get GitHub Actions running against master.

With that being said, I think we'll be able to add the new parameters from your PR. I may have a couple of style comments, but they shouldn't be anything significant.

I'll keep you posted on the progress, thanks!

jessedoyle commented 4 years ago

So I did get CI back working again!

Looks like there's a few tests failing as we're unable to rely on some of the ActiveSupport (#present?) methods.

I'll leave a formal review now, again thanks for the PR!

jessedoyle commented 4 years ago

Hi @navinspm - I'm going to close this PR as it looks like it's stale for now.

Feel free to respond if you want to get this upstream and I'd be happy to reopen it.