Closed markcraig closed 1 year ago
If this proposal is accepted, I suggest using the icon prefix "mi". This follows the naming pattern used for foundation icons.
Hey @markcraig! Thanks for using prawn-icon
. I would absolutely support a PR that implements material icons into the library.
If this proposal is accepted, I suggest using the icon prefix "mi". This follows the naming pattern used for foundation icons.
Definitely agree!
Looks like Google uses the Apache License which should be fine for distribution in this library - so no concerns there!
I'd be happy to take a stab at this over the next month or two. If anyone wants to submit a PR, the primary AC would be:
examples
directory. Here's the fontawesome example for reference.rake legend
task should execute successfully..ttf
and supporting legend .yml
file is present in data/fonts/mi
. Please include a LICENSE
file as well.Hope this helps - thanks!
I appears that this was implemented, merged, and released. Is that correct? If so, I would recommend closing this issue to avoid confusion.
Great news! Looking forward to being able to use these in asciidoctor-pdf going forward
We did cut release 3.1.0 last week that includes support for Material Design Icons.
It's worthwhile to note that the Material Design Icons collection includes the base icon set from Google as well as a large number of community-maintained icons. The full set can be viewed here.
With that being said, I'm going to close this issue. Thanks!
We plan to use Antora Assembler, which relies on
asciidoctor-pdf
to generate PDFs, which in turn relies onprawn-icon
for icon support.We are increasingly using material icons in our UIs and therefore in our docs.
It would be great if prawn-icon could add support for material icons to make them easy to use when creating PDFs.