search

jessedp / pihole5-list-tool

A tool for quickly and easily bulk adding allow and ad/block lists to a Pi-hole 5 installation
MIT License
312 stars 18 forks source link

Feature request for more detailed comments fields. #18

Open rossc719g opened 4 years ago

rossc719g commented 4 years ago

For example.. I just used this tool to import the "Non-crossed" list. All of the comments fields are the same "Firebog | Non-crossed". It would be nice if the ones which are also in the "Ticked" list showed as "Firebog | Ticked" instead, so I can tell them apart.

I'm just thinking that if I ever have an issue and need to whitelist, it will be useful to know if the list containing the site I am working on is Ticked or Non-Crossed.

I think I can probably get what I want by deleting them, and then re-running the tool twice. Once to add the Ticked list, and then again to add the Non-crossed list. (I'll give that a try next).

jessedp commented 4 years ago

As is, you can get that to happen by importing them smallest to largest since non-crossed is (always?) a super-set of ticked.

I've been talking to the guy who maintains the lists about providing slightly different ways to pull the lists, so I'd like to see where that goes before I do something weird (code-wise) like this.

rossc719g commented 4 years ago

Makes sense. As you say, I was able to get what I wanted by deleting them, and then re-running the tool twice. Once to add the Ticked list, and then again to add the Non-crossed list. So, there is nothing urgent about this.