search

jessedp / pihole5-list-tool

A tool for quickly and easily bulk adding allow and ad/block lists to a Pi-hole 5 installation
MIT License
312 stars 18 forks source link

Parsing of Entry on Firebog List #33

Closed stevefxp1 closed 3 years ago

stevefxp1 commented 3 years ago

Forms suck. But they can help a ton. Going free-form below is okay if you're certain you're providing all of the relevant information (or things aren't applicable)

Environment

Describe the system on which this issue occurred:

Version 0.6.0

Ubuntu 20.04.1 LTS

Python 3.8.5

Using Docker? N

Issue Details

I noticed that your tool is parsing an entry on the Firebog list incorrectly. The entry is https://raw.githubusercontent.com/Kees1958/W3C_annual_most_used_survey_blocklist/master/TOP_EU_US_Ads_Trackers_HOST but it shows up as https://github.com/Kees1958/W3C_annual_most_used_survey_blocklist/blob/master/TOP_EU_US_Ads_Trackers_HOST in Pi-Hole.

jessedp commented 3 years ago

That's not really possible. This tool simply parses lists to make sure entries look like a URL before using them, it doesn't change/modify/rewrite them.

I'd guess that either a previous version of one of the firebog lists used the github.com version or you loaded another set of lists that used that.

stevefxp1 commented 3 years ago

Hi Jesse,

No this is a new Pihole server and I only used your tool to load up the Firebog lists. What I will do is remove all lists and reload.

Steve

⁣ Steven F. Petrillo stevefxp@gmail.com Mobile: 1-914-907-2861​

On Dec 28, 2020, 12:53, at 12:53, jesse notifications@github.com wrote:

That's not really possible. This tool simply parses lists to make sure entries look like a URL before using them, it doesn't change/modify/rewrite them.

I'd guess that either a previous version of one of the firebog lists used the github.com version or you loaded another set of lists that used that.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/jessedp/pihole5-list-tool/issues/33#issuecomment-751807404