jesseduffield / lazygit

simple terminal UI for git commands
MIT License
53.08k stars 1.85k forks source link

files with space in the name send the wrong arguments to diff #100

Closed fiendish closed 6 years ago

fiendish commented 6 years ago

v0.1.48

git init test
cd test
touch foo\ bar
lazygit

👀 at the Diff pane

file name arguments to diff aren't being quoted, I guess?

screen shot 2018-08-09 at 1 03 09 pm

https://github.com/jesseduffield/lazygit/blob/9537645d0cfdac87addd4c9a5eb0e7df3bac8ee8/gitcommands.go#L404

jesseduffield commented 6 years ago

@fiendish I've pushed a fix based on @dawidd6's PR. Please see if that fixes the issue :)

fiendish commented 6 years ago

👍 lgtm