jesseduffield / lazygit

simple terminal UI for git commands
MIT License
52.9k stars 1.85k forks source link

Commit tab blinking commit hash & file names #1302

Open justisGipson opened 3 years ago

justisGipson commented 3 years ago

Topic Is there a way to toggle the blinking? In the commit tab, there's a box around the commit hash that blinks, and each file name in the commit tab blinks.

On:

Your thoughts Just started using lazygit yesterday, and I love it. Except for the blinking. I dug through the readme and config docs, couldn't find anything to trigger this. Also saw a couple issues where folks had a blinking issue and an upgrade resolved it. This is why I opened a discussion, wasn't sure if this was a bug or config error.

and my lazygit config:

gui:
  theme:
    selectedLineBgColor:
      - reverse
    selectedRangeBgColor:
      - reverse

git:
  paging:
    colorArg: always
    pager: delta --dark --paging=never

if needed I can grab a video or something.

EDITED 5/3/21 to include .gitconfig

[credential]
    helper = osxkeychain

[core]
    editor = nano
    pager = delta
    attributesfile = /Users/jgipson/.gitattributes

[interactive]
        diffFilter = delta --color-only
[init]
    defaultBranch = main

[color]
    diff = always
    status = always
    branch = always
    interactive = always
    decoration = always
    ui = true

[color "status"]
    added = green
    changed = red bold
    untracked = magenta bold

[color "branch"]
    current = yellow reverse
    local = green
    remote = yellow

[color "diff"]
    meta = yellow bold
    frag = magenta bold
    old = red bold
    new = green bold

[delta]
        features = side-by-side line-numbers decorations
    whitespace-error-style = 22 reverse

[delta "decorations"]
    commit-decoration-style = bold cyan box ul
    file-style = bold green ul
    file-decoration-style = none

[filter "lfs"]
    clean = git-lfs clean -- %f
    smudge = git-lfs smudge -- %f
    process = git-lfs filter-process
    required = true
[pull]
    rebase = false
justisGipson commented 3 years ago

I was able to turn this off in iTerm2 settings -> profile -> text -> toggle blinking text. I didn't realize that was on, but lazygit is also the only thing I've seen trigger the blinking text.

If this isn't worth a discussion, I can close. If it's an actual bug/feature that needs worked on, I could try to figure it out.

geins commented 3 years ago

Same issue and same solution here. But also a strange problem where the colors of diff-so-fancy emulation of delta are waaaay off.

How it looks in lazygit (blinking off by iTerm) delta

while git diff shows it right: delta2

config.yml is

  paging:
    colorArg: always
    useConfig: false
    pager: delta --paging=never

.gitconfig is

[core]
  pager = delta
[interactive]
  diffFilter = delta --color-only
[delta]
  features = line-numbers diff-so-fancy

Thank You so much!

prosoitos commented 3 years ago

I also have blinking issues with diff-so-fancy (see #1274). It's a recent thing that started with v0.27.