jesseduffield / lazygit

simple terminal UI for git commands
MIT License
53.23k stars 1.86k forks source link

Pop-up windows don't disable irrelevant key mappings #1628

Open mark2185 opened 2 years ago

mark2185 commented 2 years ago

Describe the bug Pop-up windows don't disable shortcuts, e.g. the prompt Are you sure you want to quit? allows me to press z and trigger undo. Or even press x to bring up the menu.

To Reproduce Steps to reproduce the behavior:

  1. Set confirmOnQuit: true in your config
  2. Press q in lazygit
  3. Press x or z
  4. It does the action that the key is mapped to

Expected behavior Pressing things not relevant to the pop-up shouldn't do anything

Screenshots image

Desktop (please complete the following information):

Additional context The reason I press z instead of y when quitting is because I often switch between two keyboard layouts and forget what's the current one I'm using.

escrafford commented 2 years ago

related to #1507