search

jesseduffield / lazygit

simple terminal UI for git commands
MIT License
48.03k stars 1.73k forks source link

Nerd Font Icon Support #1933

Open joshmedeski opened 2 years ago

joshmedeski commented 2 years ago

Is your feature request related to a problem? Please describe. I'd like to add the ability to customize GUI icons using nerd font.

Describe the solution you'd like Add configuration options to the yaml file that allows you to update the icons with string definitions.

Additional context I'm happy to code this myself, just need some help learning the project's folder structure.

Here's a quick idea of what I want to update (from my gitmux page)

Screen Shot 2022-05-09 at 11 45 01 AM
aur3l14no commented 2 years ago

I got "??" too. It seems it's not due to missing fonts. Was it is intentional? What was it supposed to mean?

mark2185 commented 2 years ago

The ?? is inherent to git, it represents untracked files. You'll get the same if you run git status --short.

joshmedeski commented 2 years ago

I'm working on #1934 to add more Nerd font support for the files section. I have some more work to do but I'm making progress.

mrbeardad commented 6 months ago

Is there any way to customize the icons? Because some icons are displayed different in different terminal.

joshmedeski commented 6 months ago

Perhaps the better approach here is to let people customize each icon on their own in the config. Then we don't have to worry about Nerd Font versions and user perference.

At this point the work I had done was not accepted so I'm no longer actively working on this.

mrbeardad commented 3 days ago

Is there any progress? The following picture show the commit icons in Windows Terminal.

image

joshmedeski commented 2 days ago

I opened a PR some time ago that was ultimately closed and not merged. The changes I proposed seemed too opinionated for the project.

I'm willing to put some more work if @jesseduffield can help set clear requirements.