search

jesseduffield / lazygit

simple terminal UI for git commands
MIT License
50.94k stars 1.79k forks source link

Investigate StartTicking function in gocui #2211

Open jesseduffield opened 1 year ago

jesseduffield commented 1 year ago

Every time we open a popup panel we call gui.g.StartTicking() which itself spawns a goroutine which seems to not be exited until the end of the application. This could contribute to issues if you have lazygit open for a while. We need to investigate this to see if it does cause problems and if so, we need to ensure we only ever call StartTicking once

mark2185 commented 1 year ago

Is this solved by #2345 and up for closing, then?