jesseduffield / lazygit

simple terminal UI for git commands
MIT License
50.81k stars 1.79k forks source link

Close menu in integrated neovim terminal #2425

Open xbladesub opened 1 year ago

xbladesub commented 1 year ago

Cannot close any menu (opened with x) in integrated neovim's terminal. ESC brings you to normal mode and q closes lazygit. I want to mention that in lazydocker hitting q, while any menu is opened, closes the menu - works as expected. So lazygit - doesn't work, lazydocker - works.

Steps to reproduce the behavior:

  1. Open neovim
  2. Open terminal in neovim (:term://zsh)
  3. Open lazygit
  4. Open any menu (hit x)
  5. Press ESC or press q

Expecting to close opened menu, but not entire lazygit, with q as it in lazygocker.

https://user-images.githubusercontent.com/45129790/217710186-73165fdd-88d2-4138-b9cb-b9adf2740c76.mp4

lazygit version - commit=, build date=, build source=homebrew, version=0.35, os=darwin, arch=arm64 git version - git version 2.37.1 (Apple Git-137.1)

mark2185 commented 1 year ago

This isn't really an issue with lazygit itself, but with nvim then, right?

Take a look at how do existing plugins manage to make it work.