search

jesseduffield / lazygit

simple terminal UI for git commands
MIT License
52.82k stars 1.85k forks source link

Bring back y to confirm dialogs #2611

Open J053Fabi0 opened 1 year ago

J053Fabi0 commented 1 year ago

Topic Some releases ago the option to confirm dialogs with y was removed and I think it should come back.

Your thoughts This issue is to raise awareness to the problem and see how many people upvote it, meaning they agree with me. While the enter key is a fairly universal way of confirming something, the y key is also widely spread.

Right now there's no way to enable the use of y. The following configuration mucks up the input windows

keybinding:
  universal:
    confirm: 'y'

and something like this one is not possible

keybinding:
  universal:
    confirm: ['enter' ,'y']
Vanav commented 1 year ago

I confirm this issue. Enter as not an universal "Agree", because often default button is "No" and Enter confirms it.

mark2185 commented 1 year ago

because often default button is "No"

In lazygit or in unixoids in general?

Vanav commented 1 year ago

because often default button is "No"

In lazygit or in unixoids in general?

In interfaces in general, including Unix. I think that Enter as "yes" is not obvious. Example:

rm -i test

rm: remove regular empty file 'test'?

Enter will mean "No" here.

pumbers commented 1 year ago

I agree, I found the change very confusing, and not being able to use 'y' as a positive confirmation feels very counter intuitive. At least allow either 'enter' or 'y'.

scottchiefbaker commented 6 months ago

Not having y and n as options is confusing. It would be nice to have both as an option. This gets a +1 from me.