search

jesseduffield / lazygit

simple terminal UI for git commands
MIT License
49.96k stars 1.77k forks source link

Feature request: Image previews #2787

Closed ying-z-cr closed 1 year ago

ying-z-cr commented 1 year ago

Is your feature request related to a problem? Please describe. Images are not displayed when it is highlighted in the files pane

Describe the solution you'd like Show images via a terminal image protocol eg. sixel etc.

Describe alternatives you've considered Opening a GUI file manager to preview images but I'm lazy 😆

Additional context Add any other context or screenshots about the feature request here.

mark2185 commented 1 year ago

Describe alternatives you've considered Opening a GUI file manager to preview images but I'm lazy laughing

Try pressing o when the image is selected.

ying-z-cr commented 1 year ago

I get a bunch of xdg-open: command not found. I could try to set the $BROWSER variable but then I work over an SSH connection... I could do ssh -X but the client is macOS so I don't think it'll work 🤔

mark2185 commented 1 year ago

Ah, so you're ssh-ing to a macOS machine, that's the context that is good to know when dealing with such "issues" :sweat_smile:

I'm not sure what are the plans regarding previewing things in lazygit (if any), given that it's a git wrapper, not a file manager, but in the meantime you could use a custom command with imgcat or something similar, could that be good enough for your usecase?

ying-z-cr commented 1 year ago

Ah, so you're ssh-ing to a macOS machine, that's the context that is good to know when dealing with such "issues" 😅

Whoops, sorry for not including this vital piece of information...

Anyways I shopped around for commands that could print images on the terminal but I couldn't find any good ones that would fit with my current workflow (macOS + alacritty + tmux) so I'll just give up.

Thanks for the help though! Really appreciate it 😄