search

jesseduffield / lazygit

simple terminal UI for git commands
MIT License
50.72k stars 1.79k forks source link

lazygit does not use `gui.theme.selectedLineBgColor` for the diff pane #3386

Open intelfx opened 6 months ago

intelfx commented 6 months ago

Describe the bug

Lazygit does not seem to permit customization of the the diff pane caret row background color via the gui.theme.selectedLineBgColor configuration key (or any other key, for that matter).

To Reproduce

  1. Set gui.theme.selectedLineBgColor to a custom color (anything except blue, e.g.): 
    gui:
 theme:
   selectedLineBgColor:
     - white
  2. Start lazygit with some unstaged changes
  3. Select the file with unstaged changes, press Enter to go to the diff pane
  4. Observe blue background of the caret row

Expected behavior

Expected gui.theme.selectedLineBgColor to affect the diff pane.

Screenshots

Снимок экрана от 2024-03-15 00-53-31 Снимок экрана от 2024-03-15 00-53-36

Version info:

$ lazygit --version
commit=v0.40.2, build date=2023-08-12T17:47:33Z, build source=binaryRelease, version=0.40.2, os=linux, arch=amd64, git version=2.44.0

$ git --version                                                                                                      
git version 2.44.0
stefanhaller commented 6 months ago

Not a bug. The problem is that the behavior has changed on master since the last release, and the documentation already describes the new behavior. In the last release, gui.theme.selectedRangeBgColor was used to customize the staging view.