Closed stefanhaller closed 4 months ago
Coverage variation | Diff coverage |
---|---|
Report missing for 36a46965731bfc420b9d673071b4d6adda07d87e[^1] | :white_check_mark: 96.40% |
Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.
Thanks for the quick review. I hope I made it clear enough that this can only be merged after #3613 and #3614, because it is using code that was introduced there. If those take longer to review, I could restructure the commits so that I can merge this one independently, but it's extra work that I would like to avoid if possible.
Or was the LGTM meant for all three of them?
The LGTM was only intended for this one :) I intend to get to those other two tonight
Great, thanks. No rush from my side, I'm not in a hurry to get these merged (it just sounded a bit like you did 😄)
In the rebase menu, add a command "Rebase onto base branch". This makes it more convenient to rebase onto master (or main), because
This is sitting on top of #3614.
Closes #3546.
Please check if the PR fulfills these requirements
[x] Cheatsheets are up-to-date (run
go generate ./...
)[x] Code has been formatted (see here)
[x] Tests have been added/updated (see here for the integration test guide)
[x] Text is internationalised (see here)
[x] Docs have been updated if necessary
[x] You've read through your own file changes for silly mistakes etc