search

jesseduffield / lazygit

simple terminal UI for git commands
MIT License
48.05k stars 1.73k forks source link

unstaged panel can be maximized, but staged panel cannot. #3629

Closed konosubakonoakua closed 3 weeks ago

konosubakonoakua commented 1 month ago

Describe the bug unstaged panel can be maximized, but staged panel cannot.

To Reproduce Steps to reproduce the behavior:

  1. Go to any git repo
  2. make multiple line changes
  3. open lazygit, stage any of the changes
  4. focus on staged, press + to test, then focus on unstaged, press + to test
  5. staged panel cannot be maximized, instead, the panel keeps shrinking when hitting '+'

Expected behavior staged panel should change screenmode like unstaged panel

Screenshots

staged panel cannot be maximized

If applicable, add screenshots to help explain your problem.

Version info:

commit=6fcb7eb8bb616c170506312870b3bf15f3dbe37c, build date=2024-05-19T10:15:28Z, build source=binaryRelease, version=0.42.0, os=linux, ar
ch=amd64, git version=2.45.1
JordanllHarper commented 1 month ago

Reproduced this. Initial findings seem to be when focused the staged changes pane, the '+' behaviour has the same effect as on the 'files' pane.

AzraelSec commented 1 month ago

I opened a PR to fix this issue. In the meantime, feel free to test that branch.