Closed JordanllHarper closed 4 months ago
Looks good, but please squash the second commit into the first; we want to avoid having commits that have failing tests.
Also, the PR title is very misleading, we are not renaming anything here; we are pushing a branch to a remote branch with a different name. Would be good to rename the subject (and the PR description) to make this clearer.
Apologies you're right, fixed now
Great, thanks for the contribution.
This fixes an error where, given the user wants push a branch to a remote branch with a different name, the following error would be presented:
Please check if the PR fulfills these requirements
[x] Cheatsheets are up-to-date (run
go generate ./...
)[x] Code has been formatted (see here)
[x] Tests have been added/updated (see here for the integration test guide)
[x] Text is internationalised (see here)
[x] Docs have been updated if necessary
[x] You've read through your own file changes for silly mistakes etc