jesseduffield / lazygit

simple terminal UI for git commands
MIT License
47.94k stars 1.72k forks source link

Fix truncation of branch names containing non-ASCII characters #3685

Closed stefanhaller closed 1 week ago

stefanhaller commented 1 week ago

Fix truncating long branch names containing non-ASCII characters.

Before:

image

After:

image
codacy-production[bot] commented 1 week ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for a171ec42943c048e4210bd6beac64aa138ea7c56[^1] :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (a171ec42943c048e4210bd6beac64aa138ea7c56) | Report Missing | Report Missing | Report Missing | | | Head commit (d406ec06af1f671e3370d120deb439af3cad7fa4) | 52182 | 45129 | 86.48% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3685) | 4 | 4 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

stefanhaller commented 1 week ago

Yeah, to be honest it's not a problem that I ran into myself; I just noticed this while working on the code (for #3686). But I suppose it could be an issue for east asian people using their native language in branch names.