jesseduffield / lazygit

simple terminal UI for git commands
MIT License
47.94k stars 1.72k forks source link

Make commit author length configurable, take 2 #3688

Closed stefanhaller closed 3 days ago

stefanhaller commented 1 week ago

This reverts #3625, and instead adds two new config keys commitAuthorShortLength and commitAuthorLongLength for achieving the same thing, but with more flexibility.

codacy-production[bot] commented 1 week ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5dbdbd8425b0319c4c78bc2453c10f8bf988f252[^1] :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (5dbdbd8425b0319c4c78bc2453c10f8bf988f252) | Report Missing | Report Missing | Report Missing | | | Head commit (bd782f16ddde1bdff6ee6e5237826be25e90fa9d) | 48711 | 41617 | 85.44% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3688) | 21 | 21 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

stefanhaller commented 5 days ago

@anikiforov I'd like to merge this, but I feel bad about reverting your earlier PR without your approval. Could you please have a look to see if this works for you?

anikiforov commented 3 days ago

@stefanhaller, no worries, feel free to revert my change. Having separate settings for separate views certainly is better. I will test this change in my copy next week.