jesseduffield / lazygit

simple terminal UI for git commands
MIT License
47.94k stars 1.72k forks source link

Stagger popup panels #3694

Closed stefanhaller closed 4 days ago

stefanhaller commented 5 days ago

Sometimes we open a popup panel on top of another one; an example is the <c-o> menu in the commit message editor, or the "add co-author" prompt that appears on top of the commit message panel. We just added a new one in #3676, which is the confirmation that appears when pasting a commit message over an existing one.

Currently, these panels are sized and positioned independently of each other, which looks ugly and makes it hard to see what's going on:

image

Improve this by offsetting the new panel a bit down and to the right from the one below it:

image

Along the way we clean up the code a bit and fix a few minor issues; see the individual commit messages for details.

codacy-production[bot] commented 5 days ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 63a523c2fcfac708c1c070cd4b550b4f41986555[^1] :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (63a523c2fcfac708c1c070cd4b550b4f41986555) | Report Missing | Report Missing | Report Missing | | | Head commit (4b6479b25f8fcbacb360ee18ef3359cfeee8bd8c) | 48681 | 41575 | 85.40% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3694) | 51 | 51 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.