jesseduffield / lazygit

simple terminal UI for git commands
MIT License
47.94k stars 1.72k forks source link

Always reapply filters on filtered views when model changes, even inactive ones #3697

Closed stefanhaller closed 3 days ago

stefanhaller commented 4 days ago

A filtered view would show stale data when the model changes but the view is inactive. I think this could only happen when changing some git state outside of lazygit; for example, when creating a new branch while the branches panel has a filter set, but doesn't have the focus. (See the added test for an example.)

codacy-production[bot] commented 4 days ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 26c3e0d333a0e4404080b9fa3081fc2364367f20[^1] :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (26c3e0d333a0e4404080b9fa3081fc2364367f20) | Report Missing | Report Missing | Report Missing | | | Head commit (e205c6ba7f65e566eeee0a08c08cde245a0493f9) | 48706 | 41606 | 85.42% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3697) | 23 | 23 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.