jesseduffield / lazygit

simple terminal UI for git commands
MIT License
48.13k stars 1.73k forks source link

Emoji '🧑‍💻' is not correctly handled #3711

Open Saafo opened 5 days ago

Saafo commented 5 days ago

Describe the bug The emoji '🧑‍💻' which you can copied here and paste to lazygit, is not correctly handled by lazygit's editor and display component.

To Reproduce Steps to reproduce the behavior:

  1. Copy the emoji above
  2. open commit panel in lazygit
  3. paste
  4. It will split into two glyphs and discarding the joiner <200d>, which will result in never displaying '🧑‍💻' in other software which should support displaying it, like Github.
  5. If I paste this emoji in nvim and commit, it can correctly display '🧑‍💻' in other software which can correctly displaying it, but it's still odd in Lazygit's commit history(displaying '🧑💻')

Expected behavior Display '🧑‍💻' or display '🧑<200d>💻' like nvim editor are both ok to me, the former is better for sure.

Screenshots Lazygit editor

image

Nvim editor

image

Lazygit commit history

image

Version info: Run lazygit --version and paste the result here 0.42.0 Run git --version and paste the result here

Additional context

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.