Allow customize Shell & ShellArg in config.yml

jesseduffield / lazygit

simple terminal UI for git commands

MIT License

49.81k stars 1.77k forks source link

Allow customize Shell & ShellArg in config.yml #3749

Open yam-liu opened 1 month ago

yam-liu commented 1 month ago

Is your feature request related to a problem? Please describe. I have tons of aliases but cannot use them directly in Lazygit because bash is the default shell. I use zsh. I found some solutions like zsh -ic, but I need to prefix it every time, it is so inconvenient. CleanShot 2024-07-15 at 13 35 25@2x

Describe the solution you'd like Support customization in config.yml like:

os:
  shell: "",
  shellArg: "",

Describe alternatives you've considered Detect user shell and support alias. I found a closed PR, but didn't dig into it, maybe there are some bugs in that implementation?

Additional context None

stefanhaller commented 1 month ago

This could be considered a duplicate of #770 and #1642.

There are two possible approaches to solving this:

Always use the user's shell (as specified in the $SHELL env variable), and unconditionally add -i, under the assumption that all modern shells support it. This has been tried in #2096. If I understand correctly, there were problems with this approach; if we can get this to work, it would be my preferred solution because it doesn't need a any user config.
Make the shell (and shell args) configurable like you suggest. This has been tried in #3299, which, as far as I can see, implements exactly what you are proposing.

yam-liu commented 1 month ago

@stefanhaller Thanks for the quick and detailed reply. I am glad to see there are already solutions for this issue. I noticed the first SHELL solution (S1) and it has problems. So I prefer solution 2 (S2).

So before we figure that issue (in S1) out and fix it, can we push the shell(Arg) solution (S2) a step forward? It has been for a long while (roughly 4 months), may I know what the current blocking point is?