search

jesseduffield / lazygit

simple terminal UI for git commands
MIT License
52.66k stars 1.84k forks source link

Panel Selection Inversion #3760

Closed geomorillo closed 3 months ago

geomorillo commented 3 months ago

Describe the bug When using LazyGit, there appears to be an issue with the panel selection indicators in panels 1 and 2. When pressing the key '1', it should select panel 1, and pressing '2' should select panel 2. However, the selection is inverted: pressing '1' selects panel 2, and pressing '2' selects panel 1.

To Reproduce Steps to reproduce the behavior:

  1. Open LazyGit.
  2. Attempt to select panel 1 by pressing the '1' key.
  3. Observe that panel 2 is selected instead.
  4. Attempt to select panel 2 by pressing the '2' key.
  5. Observe that panel 1 is selected instead.

Expected behavior

Screenshots number

Version info: commit=71ad3fac63a3ef3326021837b49e9497d332818b, build date=2024-07-13T10:24:19Z, build source=binaryRelease, version=0.43.1, os=windows, arch=amd64, git version=2.45.2.windows.1

git version 2.45.2.windows.1

Additional context This issue affects usability as it leads to confusion when navigating between panels. It would be helpful to have this corrected to ensure intuitive panel selection.

mark2185 commented 3 months ago

Have you maybe made any remappings in your config.yml?

I tried it on latest master (on linux, but still), but can't reproduce it.

stefanhaller commented 3 months ago

Remappings wouldn't explain it, this would also show the remapped keys in the panel titles. You can try that by using

keybinding:
  universal:
    jumpToBlock:
      - "2"
      - "1"
      - "3"
      - "4"
      - "5"

@geomorillo I have no idea how this could be explained, sorry. Works correctly for me.

geomorillo commented 3 months ago

Thanks for the quick response. There seems to be a misunderstanding.

I initially thought there was an inversion issue with the panel selection indicators, but after playing with it for a bit, I realized the panels are selected correctly. However, the color change when a panel is selected is causing me confusion. The selected panel becomes darker, which gives the impression that it is not the active panel. Maybe changing the color to something like a light green would make it clearer?, so i will close this issue since it is not a bug thanks