search

jesseduffield / lazygit

simple terminal UI for git commands
MIT License
52.81k stars 1.85k forks source link

Confirmation popup for destructive actions #874

Open no-more-secrets opened 4 years ago

no-more-secrets commented 4 years ago

Hello,

In the two menus containing "destructive" actions (d and D) can we have the "cancel" item first in the list? That way one doesn't accidentally hit enter and nuke their tree. Especially important since when you select one of those destructive actions there is not an "are you sure?" box that pops up. I think that the best solution which will keep the UI streamlined but make it a tad safer would just be to have the "cancel" item first in the list. That way, in order to nuke your tree, you have to press shift-d, down arrow, then enter, i.e., a key sequence that will only ever be typed intentionally. What say you?

jesseduffield commented 4 years ago

I'm currently leaning towards leaving it as-is given that the fact you already have to press two keys is sufficient friction in my mind (i.e. d + enter), but I'm interested in other people's thoughts

no-more-secrets commented 4 years ago

If changing the order of the menu items is not desirable, then can we add an "are you sure" box? I don't know any UI in any system that would not present an "are you sure" box in response to a user action that discards all of their changes :)

jesseduffield commented 4 years ago

Good point, I think that makes sense

no-more-secrets commented 4 years ago

Great, thank you

guerinoni commented 1 year ago

I think we have this rn

no-more-secrets commented 1 year ago

@guerinoni Are you referring to PR #874? It looks like that was not merged, but closed due to staleness. @sstiglitz Any plans to finish that PR?

ikorason commented 5 months ago

Hello @jesseduffield

I just checked when I try to delete files or branches and there is already cancel option shown but it's still not default focus.

I see this issue is good for noobs like me and wonder if I can still contribute? Or are there other plans for this?

Thank you in advance