search

jessegavin / jQuery-Chord-Transposer

jQuery plugin that lets you transpose chords in a plain text song
https://jquery-chord-transposer.now.sh/
113 stars 48 forks source link

Some chords not recognized #4

Closed filipblaauw closed 6 years ago

filipblaauw commented 8 years ago

I'm having trouble with some chords, and I have not yet figured out the pattern yet.

m7b5, sus4, m7#5, 7#9 are some of the chords where only part of the chords are wrapped in the span. On transpose, the parts that's not in the span, is skipped.

skjermbilde 2016-07-04 kl 22 28 39

Update: I got it working by adding 4, b5 and #5 to the regex list.

jessegavin commented 8 years ago

Those are some funky chords. You're right, they're probably missing from the Regex.

Would you be willing to submit a pull request? If not, just let me know where how you changed the Regex and I can implement it.

Thanks for posting this.

filipblaauw commented 8 years ago

I've submitted a PR On a sidenote: the chords in my example indeed sound funky. They are not there for musical reasons, more a "chord regex debug" version of the song :)