jessegmeyerlab / proteomics-tutorial

Other
49 stars 29 forks source link

Update 13.biological-interpretation.md #24

Closed norbertvolkmar closed 1 year ago

norbertvolkmar commented 2 years ago

work in progress

Please provide a description of your changes:

Please check the following about your suggested changed:

norbertvolkmar commented 2 years ago

I am aiming to develop this section further, especially related to the biological interpretation of structural proteomics data. This chapter might also benefit from a nice overview figure.

jessegmeyerlab commented 2 years ago

Thanks Norbert, will wait to review this until you give word

jessegmeyerlab commented 2 years ago

@norbertvolkmar here is a figure made by @ArokiaRex for this section - posting here so I remember to add after we merge your edits.

Any thoughts or suggestions would be appreciated

Fig_12_Biological interpretation_1 (1)

norbertvolkmar commented 2 years ago

Excellent. Beautiful figure - thank you!

norbertvolkmar commented 2 years ago

i am not sure when i'll be able to continue work on this section, so it might be best to approve the pull request for now?

jessegmeyerlab commented 2 years ago

i am not sure when i'll be able to continue work on this section, so it might be best to approve the pull request for now?

Got it thanks. I will look at this today and might have comments.

jessegmeyerlab commented 2 years ago

Thanks for working on this. Overall there are some good concept additions here. Can you please add citations and make sure the text is one line per sentence?

For the scope of a contribution to earn authorship, I'm hoping for at least five complete paragraphs. Each contribution needs to be assessed on a case by case basis though.

norbertvolkmar commented 2 years ago

No problem! I will keep working on it, just didn't have the time lately and didn't want to block anyone else from adding to it.

Norbert


From: jessegmeyerlab @.***> Sent: 16 March 2022 16:59 To: jessegmeyerlab/proteomics-tutorial Cc: Volkmar Norbert; Mention Subject: Re: [jessegmeyerlab/proteomics-tutorial] Update 13.biological-interpretation.md (PR #24)

Thanks for working on this. Overall there are some good concept additions here. Can you please add citations and make sure the text is one line per sentence?

For the scope of a contribution to earn authorship, I'm hoping for at least five complete paragraphs. Each contribution needs to be assessed on a case by case basis though.

— Reply to this email directly, view it on GitHubhttps://github.com/jessegmeyerlab/proteomics-tutorial/pull/24#issuecomment-1069290887, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXKWRABL2SN7V7P4XHPT2RTVAIAPJANCNFSM5NLMXS6A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/jessegmeyerlab/proteomics-tutorial/pull/24#issuecomment-1069290887", "url": "https://github.com/jessegmeyerlab/proteomics-tutorial/pull/24#issuecomment-1069290887", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

norbertvolkmar commented 2 years ago

just a general question (might be misplaced in this thread) - I haven't seen any activity on this review for 2 months now and the April 1 deadline has passed. Is this project still alive or has the prospect of submitting this review anytime soon been abandoned?

jessegmeyerlab commented 2 years ago

just a general question (might be misplaced in this thread) - I haven't seen any activity on this review for 2 months now and the April 1 deadline has passed. Is this project still alive or has the prospect of submitting this review anytime soon been abandoned?

Thanks for checking in.

I think the original deadline was too ambitious. On my end it was slowed down by me moving my lab across the country. We are getting settled jn now and if we can submit by the end of the year that would be more realistic. It will depend on who I hire and who we can recruit through social media to help with the project. I requested an extension from the journal.

I recently received a section on databases from someone by email I need to add, and I know someone else is working on another section. I would be grateful for your contribution if you find the time.

jessegmeyerlab commented 1 year ago

@norbertvolkmar since it sounds like you are working on this section separately I will close this pull request for now and wait for your new one