draft section by edoud1

[jessegmeyerlab]

moving from jgmeyerucsd repo fork

Please provide a description of your changes:

Please check the following about your suggested changed:

• [x] The new text has one sentence per line
• [x] preprints that are cited are listed as an issue for discussion and peer review

Changes suggested by @edoud1 - need to review

[jessegmeyerlab]

@edoud1 overall this is great thank you! I suggest some edits and ask for clarification or citations in a few places. If you agree with suggestions you can click the accept buttons. To add citations please use the format [@pmid:number] or [@doi:10.1021/ac504689z].

@edoud1 to work on this branch use this version https://github.com/jessegmeyerlab/proteomics-tutorial/blob/jessegmeyerlab-edoud1/content/04.protein-extraction.md

[edoud1]

Can do - these edits look great and I'll pull some new references/address your comments.

[jessegmeyerlab]

Thanks Emma - let me know if you need help figuring out how to add the changes, and make sure to add your author info to the metadata.yml on this branch

[edoud1]

Hey Jesse, Can we merge these changes and then I'll add in on those comments/requested citations? Just to keep things clean and avoid missing any changes. It's not giving me the option to 'approve and merge' unless I'm missing it somewhere! Which I fully admit I might be. I'll try to get my end updated before ASMS - see you there?

[jessegmeyerlab]

Hey Jesse, Can we merge these changes and then I'll add in on those comments/requested citations? Just to keep things clean and avoid missing any changes. It's not giving me the option to 'approve and merge' unless I'm missing it somewhere! Which I fully admit I might be. I'll try to get my end updated before ASMS - see you there?

You are correct I am the only one who can approve and merge on the main branch of this repository as of right now. Yes I will be at ASMS and chairing the session on AI in MS research Tuesday afternoon!

Before we merge this, you can accept each of the suggested changes if you agree by clicking the "commit suggestion" buttons:

After that, it should be okay to merge this for now and then have you add edits on top of the main branch again in a new pull request (PR).

Just so you know how to add to this branch for this PR (and in case anyone else reads this who wants to know how), if you wanted to add those edits on this PR, you can open the branch that this PR comes from by clicking on the branch at the top and then add the edits there.

---

---

You can check that that file is on the correct branch of the PR

---

and then commit changes making sure they are again to that branch being considered for a PR:

[edoud1]

I'm not seeing the option to "commit changes" anywhere?

[jessegmeyerlab]

ok thanks for letting me know. maybe its because I made this pull request. I will accept everything and we can try having you add new changes to the base branch again.

[jessegmeyerlab]

OK its done! thanks for your help

[jessegmeyerlab]

@edoud1 I noticed that some of the citations are not formatted correctly so they are misbehaving in the HTML version that is automatically generated. Can you please fix these in you new pull request if you notice them? The format should be [@PMID:34002278]

[edoud1]

Thanks for catching - I'll update on the next round where I address your earlier comments! On the to do list for prior to the plane on Saturday....