jessegmeyerlab / proteomics-tutorial

Other
51 stars 30 forks source link

biological intepretation #58

Closed ococrook closed 1 year ago

ococrook commented 1 year ago

Please provide a description of your changes:

add a biological intepretation section with computational methods includes

Does not include experimental approaches

Please check the following about your suggested changed:

jessegmeyerlab commented 1 year ago

This is awesome thank you!

Two questions:

Are you still working on this or it's ready for review ?

I remember some discussion about people working together on some sections - is there anyone else who helped with this? If so please tag their github name so we can count lines to them when determining authorship.

norbertvolkmar commented 1 year ago

I am still to upload a section on orthogonal biological approaches. This section would focus on not only computational processing of the data but actually validating assumptions made based on the data (using both MS and MS-independent approaches)

jessegmeyerlab commented 1 year ago

Thanks for the information and thanks for adding the text Oliver. Someone else was also working on the same section at the same time and I just merged their changes with main. This is inevitable in an open project like this. It looks like you both added complementary ideas, so I need to try to merge the text. Please feel free to make a new PR trying to merge yours with theirs otherwise I can try to do it before next week Monday.

ococrook commented 1 year ago

That's no problem Jesse. I can have a look at merging the ideas together this week. I realise you want to get this finished asap

jessegmeyerlab commented 1 year ago

closing this for simplicity as I added Oliver's changes in #61 - @norbertvolkmar please open a new pull request with your additions when you have them