Closed lichenlady94 closed 1 year ago
@lichenlady94 are you ready for review of this draft or still working on it?
I think it's ready for review! There are some sections that'll still need to be written but the changes I made should cover a decent bit.
On Mon, Feb 6, 2023 at 11:22 PM jessegmeyerlab @.***> wrote:
@lichenlady94 https://github.com/lichenlady94 are you ready for review of this draft or still working on it?
— Reply to this email directly, view it on GitHub https://github.com/jessegmeyerlab/proteomics-tutorial/pull/59#issuecomment-1420180421, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZY72SUEC7UVPCLORCKYNODWWHEXDANCNFSM6AAAAAATUDPHPU . You are receiving this because you were mentioned.Message ID: @.***>
I think it's ready for review! There are some sections that'll still need to be written but the changes I made should cover a decent bit. … On Mon, Feb 6, 2023 at 11:22 PM jessegmeyerlab @.> wrote: @lichenlady94 https://github.com/lichenlady94 are you ready for review of this draft or still working on it? — Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZY72SUEC7UVPCLORCKYNODWWHEXDANCNFSM6AAAAAATUDPHPU . You are receiving this because you were mentioned.Message ID: @.>
OK thanks - I have several big deadlines around the end of the month so I might not look at this until early March
OK this is a great start. Most of the edits are to put each sentence on its own line. I tried to add/remove some stuff so that we can be ready to submit soon. Can you please check these points and make the suggested edits? @lichenlady94
Sure can! I'll be working on it starting tomorrow! And just so there's not too much back and forth, Each number line just have one sentence correct?
OK this is a great start. Most of the edits are to put each sentence on its own line. I tried to add/remove some stuff so that we can be ready to submit soon. Can you please check these points and make the suggested edits? @lichenlady94
Sure can! I'll be working on it starting tomorrow! And just so there's not too much back and forth, Each number line just have one sentence correct?
Yes, only one sentence per line. That way its easier to track if someone wants to change one sentence.
Let me know when you think its ready for re-review. Thank you!
Do you have a recommendation for putting website links in? I found this and would probably be good to incorporate it. https://www.eubopen.org/sites/www.eubopen.org/files/attachments/2022/LiP-MS%20protocol.pdf
Do you have a recommendation for putting website links in? I found this and would probably be good to incorporate it. https://www.eubopen.org/sites/www.eubopen.org/files/attachments/2022/LiP-MS%20protocol.pdf
You can do [@URL:] just like the doi or pmid citations, manubot will figure it out.
Sorry if I missed that you are done with section updates?
Thanks! Give me till the end of this week and I'll have it done. It's been busy writing a couple manuscripts at the same time. Sorry!
On Wed, Mar 22, 2023, 3:42 PM jessegmeyerlab @.***> wrote:
Do you have a recommendation for putting website links in? I found this and would probably be good to incorporate it. https://www.eubopen.org/sites/www.eubopen.org/files/attachments/2022/LiP-MS%20protocol.pdf
You can do @.*** https://github.com/url:] just like the doi or pmid citations, manubot will figure it out.
Sorry if I missed that you are done with section updates?
— Reply to this email directly, view it on GitHub https://github.com/jessegmeyerlab/proteomics-tutorial/pull/59#issuecomment-1480154602, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZY72SRGZJCUSJMVSVFMI4LW5NIYTANCNFSM6AAAAAATUDPHPU . You are receiving this because you were mentioned.Message ID: @.***>
Hi Jesse, the section is ready.
Thank you, I'll be going through it and finishing it up by tomorrow!
Thank you, I'll be going through it and finishing it up by tomorrow!
Great thanks! If you finish all this stuff can you please also add your info to the metadata.yml in this pull request so that we can be sure you automatically get added as author when it goes through?
@jessegmeyerlab I think I have everything together now.
@jessegmeyerlab I think I have everything together now.
Thanks I will review tonight
Okay, I was working on a new computer and it was glitching up on me, but let me triple check before letting you know again.
I've added in the phosphoproteomics and glycoproteomics and set up the next sections for the other experiments. I can add more to the sections that I've covered already if you think it needs more.
Please provide a description of your changes:
Please check the following about your suggested changed: